lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070329124535.GA20019@linux-sh.org>
Date:	Thu, 29 Mar 2007 21:45:35 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	"Wu, Bryan" <bryan.wu@...log.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blackfin arch fix stamp537 ISP1716 IRQ setting bug

On Thu, Mar 29, 2007 at 06:47:32PM +0800, Wu, Bryan wrote:
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 0f90ff9..a4219df 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -68,7 +68,7 @@ static struct resource bfin_isp1761_resources[] = {
>  	[1] = {
>  		.start  = ISP1761_IRQ,
>  		.end    = ISP1761_IRQ,
> -		.flags  = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
> +		.flags  = IORESOURCE_IRQ,
>  	},
>  };
>  
So you've left the logic for set_irq_type(), yes? In that case, this
looks fine.

I'd add an Acked-by, but it probably doesn't matter :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ