[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <460BBD1B.4040308@ru.mvista.com>
Date: Thu, 29 Mar 2007 17:20:27 +0400
From: Sergei Shtylyov <sshtylyov@...mvista.com>
To: Maxim <maximlevitsky@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Ingo Molnar <mingo@...e.hu>,
Thomas Gleixner <tglx@...utronix.de>,
Jeff Chua <jeff.chua.linux@...il.com>,
Adrian Bunk <bunk@...sta.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
"Rafael J. Wysocki" <rjw@...k.pl>, pavel@...e.cz,
linux-pm@...ts.osdl.org, gregkh@...e.de,
linux-pci@...ey.karlin.mff.cuni.cz,
Jens Axboe <jens.axboe@...cle.com>,
Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
jgarzik@...ox.com, linux-ide@...r.kernel.org,
"Michael S. Tsirkin" <mst@...lanox.co.il>
Subject: Re: [ PATCH] Add suspend/resume for HPET was: Re: [3/6] 2.6.21-rc4:
known regressions
Hello.
Maxim wrote:
> ---
> This adds support of suspend/resume on i386 for HPET
The part after usually "---" gets cut off, the patch description and
signoff should actially *precede* it.
> Signed-off-by: Maxim Levitsky <maximlevitsky@...il.com>
> diff --git a/arch/i386/kernel/hpet.c b/arch/i386/kernel/hpet.c
> index 0fd9fba..7c67780 100644
> --- a/arch/i386/kernel/hpet.c
> +++ b/arch/i386/kernel/hpet.c
[...]
> +static __init int hpet_register_sysfs(void)
> +{
> + int err;
> +
> + if (!is_hpet_capable())
> + return 0;
> +
> + err = sysdev_class_register(&hpet_class);
> +
> + if (!err) {
> + sysdev_register(&hpet_device);
> + if (err)
> + sysdev_class_unregister(&hpet_class);
This doesn't make sense, err will always be 0. Perhaps you actually
intended to check the result of sysdev_register()?
> + }
> +
> + return err;
> +}
> +
> +device_initcall(hpet_register_sysfs);
> +
> +#endif
WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists