[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200703300006.24960.ak@suse.de>
Date: Fri, 30 Mar 2007 00:06:22 +0200
From: Andi Kleen <ak@...e.de>
To: Andreas Mohr <andi@...x01.fht-esslingen.de>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Mark Langsdorf <mark.langsdorf@....com>,
Len Brown <lenb@...nel.org>,
"Morrow, William" <William.Morrow@....com>,
"Crouse, Jordan" <jordan.crouse@...mail.amd.com>,
Thomas Gleixner <tglx@...utronix.de>,
Pavel Machek <pavel@....cz>, Ingo Molnar <mingo@...e.hu>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Nick Piggin <nickpiggin@...oo.com.au>,
Mingming Cao <cmm@...ibm.com>, Adrian Bunk <bunk@...sta.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
Mariusz Kozlowski <m.kozlowski@...land.pl>,
Oliver Pinter <oliver.pntr@...il.com>,
Sid Boyce <g3vbv@...eyonder.co.uk>,
Nick Piggin <npiggin@...e.de>,
Jens Axboe <jens.axboe@...cle.com>,
Thomas Renninger <trenn@...e.de>
Subject: Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok"
On Thursday 29 March 2007 23:45, Andreas Mohr wrote:
> Hi,
>
> On Thu, Mar 29, 2007 at 02:16:54PM -0700, Linus Torvalds wrote:
> >
> >
> > On Thu, 29 Mar 2007, Andi Kleen wrote:
> > >
> > > Here's a patch. I don't have a system with C1E, so i only tested that
> > > the apic timer still works on a older AMD box.
> >
> > I think this looks better than what we have now, but it would look even
> > better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we
> > simply had X86_FEATURE_BROKEN_C1_LAPIC etc..
>
> Please don't, this would break the interface logically.
We already have several of those. And negative is much easier.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists