[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070329152455.1be1fe2f.randy.dunlap@oracle.com>
Date: Thu, 29 Mar 2007 15:24:55 -0700
From: Randy Dunlap <randy.dunlap@...cle.com>
To: ebiederm@...ssion.com (Eric W. Biederman)
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Helge Hafting <helgehaf@...el.hist.no>,
linux-kernel@...r.kernel.org
Subject: Re: 2.6.21-rc5-mm2 - compile error on x86-64
On Thu, 29 Mar 2007 16:10:50 -0600 Eric W. Biederman wrote:
> Andrew Morton <akpm@...ux-foundation.org> writes:
> >
> > Ah. I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?
> >
> >
> >
> >
> > From: Andrew Morton <akpm@...ux-foundation.org>
> >
> > We're using #ifdef CONFIG_SYSCTL, but we should be using CONFIG_PROC_SYSCTL,
> > so we get
>
> I have no problem with the patch it is clearly more correct than what we
> are doing now but I didn't think it was possible to select
> CONFIG_SYSCTL and CONFIG_PROCFS without CONFIG_PROC_SYSCTL being
> selected...
> Do we have a constraint problem in Kconfig? Or am I misremembering things?
Hi Eric,
Looks like you are just misremembering things...
> > fs/built-in.o: In function `proc_root_init':
> > /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'
> >
> > Fix that up and remove an ifdef-in-C.
> >
> > Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> > Cc: Helge Hafting <helgehaf@...el.hist.no>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists