linux-kernel - Re: [QUESTION] check for mem in slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020703300455i4fe6bdc5yf4389c2105487bb0@mail.gmail.com>
Date:	Fri, 30 Mar 2007 14:55:26 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Heiko Carstens" <heiko.carstens@...ibm.com>
Cc:	"Cyrill Gorcunov" <gorcunov@...il.com>,
	linux-kernel-list <linux-kernel@...r.kernel.org>
Subject: Re: [QUESTION] check for mem in slab

On 3/30/07, Heiko Carstens <heiko.carstens@...ibm.com> wrote:
> > in file mm/slab.c and routine kmem_cache_init() I found there
> > is no checking for allocated memory on line:
> >
> >       /* 4) Replace the bootstrap head arrays */
> >       {
> >               struct array_cache *ptr;
> >
> >               ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL);
> >
> > --> no check for ptr == NULL <--
> [...]
> > is that OK? or it's a bug?
>
> It's ok. If that allocation fails your machine won't come up anyway.

We ought to add a BUG_ON or comment at least there as this keeps
popping up again and again.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/