linux-kernel - Re: Why is arch/s390/crypto/Kconfig sourced when building for another arch ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703301810160.19277@CPE00045a9c397f-CM001225dbafb6>
Date:	Fri, 30 Mar 2007 18:15:04 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Jan Glauber <jang@...ux.vnet.ibm.com>
cc:	Thomas Backlund <tmb@...driva.org>, linux-kernel@...r.kernel.org
Subject: Re: Why is arch/s390/crypto/Kconfig sourced when building for another
 arch ?

On Fri, 30 Mar 2007, Jan Glauber wrote:

> On Fri, 2007-03-30 at 05:55 -0400, Robert P. J. Day wrote:
> >   i'm betting the S390 folks would *really* hate that idea but, if you
> > look closely, the generic Kconfig file *already* has some
> > arch-dependent content:
> >
> > ...
> > config CRYPTO_DEV_PADLOCK
> >         tristate "Support for VIA PadLock ACE"
> >         depends on X86_32     <-----
> > ...
>
> Yes, but the padlock driver is located under drivers/crypto. The
> s390 crypto stuff is not. It is under arch/s390/crypto, thats why
> the Kconfig file is there...

  which differs from the way it's handled with x86_64.  even though
the actual crypto routines specific to x86_64 are in
arch/x86_64/crypto (as they are with s390), the menuconfig selections
for them are defined in the *generic* crypto/Kconfig file:

...
config CRYPTO_TWOFISH_X86_64
        tristate "Twofish cipher algorithm (x86_64)"
        depends on (X86 || UML_X86) && 64BIT
        select CRYPTO_ALGAPI
        select CRYPTO_TWOFISH_COMMON
        help
          Twofish cipher algorithm (x86_64).

          Twofish was submitted as an AES (Advanced Encryption Standard)
          candidate cipher by researchers at CounterPane Systems.  It is a
          16 round block cipher supporting key sizes of 128, 192, and 256
          bits.

          See also:
          <http://www.schneier.com/twofish.html>
...

  a little consistency would be nice.  :-)

rday

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/