linux-kernel - Re: [PATCH] Cleanup: i386 separate hardware-defined TSS from Linux additions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1175233471.12230.371.camel@localhost.localdomain>
Date:	Fri, 30 Mar 2007 15:44:31 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Andi Kleen <ak@...e.de>, akpm@...ux-foundation.org, bunk@...sta.de,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Cleanup: i386 separate hardware-defined TSS from Linux
	additions

On Thu, 2007-03-29 at 21:33 -0500, Matt Mackall wrote:
> >  	unsigned short	gs, __gsh;
> >  	unsigned short	ldt, __ldth;
> >  	unsigned short	trace, io_bitmap_base;
> > +} __attribute__((packed));
> > +
> > +struct tss_struct {
> > +	struct i386_hw_tss x86_tss;
> > +
> >  	/*
> >  	 * The extra 1 is there because the CPU will access an
> >  	 * additional byte beyond the end of the IO permission
> 
> This comment needs to stay in the first struct..?

Hi Matt!

	Actually, it refers to the next field.  To give complete context:

	/*
	 * The extra 1 is there because the CPU will access an
	 * additional byte beyond the end of the IO permission
	 * bitmap. The extra byte must be all 1 bits, and must
	 * be within the limit.
	 */
	unsigned long	io_bitmap[IO_BITMAP_LONGS + 1];

Cheers,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/