linux-kernel - Re: drivers/video/aty/atyfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 31 Mar 2007 09:23:29 +0800
From:	"Antonino A. Daplas" <adaplas@...il.com>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Richard Purdie <rpurdie@...ys.net>, linux-kernel@...r.kernel.org,
	Ville Syrjälä <syrjala@....fi>
Subject: Re: drivers/video/aty/atyfb_base.c: array overruns

On Mon, 2007-03-19 at 10:22 +0100, Adrian Bunk wrote:
> The Coverity checker spotted the following two array overruns in 
> drivers/video/aty/atyfb_base.c:
> 
> <--  snip  -->
> 
> ...
> static const u32 lt_lcd_regs[] = {
>         CONFIG_PANEL_LG,
>         LCD_GEN_CNTL_LG,
>         DSTN_CONTROL_LG,
>         HFB_PITCH_ADDR_LG,
>         HORZ_STRETCHING_LG,
>         VERT_STRETCHING_LG,
>         0, /* EXT_VERT_STRETCH */
>         LT_GIO_LG,
>         POWER_MANAGEMENT_LG
> };

We can pad this array with zeroes, as a stop-gap measure. Ville, what do
you think?

Tony

> 
> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par)
> {
>         if (M64_HAS(LT_LCD_REGS)) {
>                 aty_st_le32(lt_lcd_regs[index], val, par);
> ...
> }
> ...
> u32 aty_ld_lcd(int index, const struct atyfb_par *par)
> {
>         if (M64_HAS(LT_LCD_REGS)) {
>                 return aty_ld_le32(lt_lcd_regs[index], par);
> ...
> }
> ...
> static int aty_bl_update_status(struct backlight_device *bd)
> {
>         struct atyfb_par *par = class_get_devdata(&bd->class_dev);
>         unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
> ...
>         aty_st_lcd(LCD_MISC_CNTL, reg, par);
> 
>         return 0;
> }
> ...
> 
> <--  snip  -->
> 
> LCD_MISC_CNTL = 0x14 = 20 > 8
> 
> cu
> Adrian
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/