linux-kernel - Re: driver core: do not wait unnecessarily in driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070402072858.GA19241@kroah.com>
Date:	Mon, 2 Apr 2007 00:28:58 -0700
From:	Greg KH <greg@...ah.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: driver core: do not wait unnecessarily in driver_unregister()

On Sun, Apr 01, 2007 at 08:59:02PM +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f5ef2abcbeb5b0be23f7cc610a024b2406e3d8e6
> Commit:     f5ef2abcbeb5b0be23f7cc610a024b2406e3d8e6
> Parent:     755948cfca16c71b16e8ff4a9d4dd31b1c0bf923
> Author:     Linus Torvalds <torvalds@...dy.linux-foundation.org>
> AuthorDate: Sun Apr 1 10:54:13 2007 -0700
> Committer:  Linus Torvalds <torvalds@...dy.linux-foundation.org>
> CommitDate: Sun Apr 1 10:54:13 2007 -0700
> 
>     driver core: do not wait unnecessarily in driver_unregister()
>     
>     Ingo reported that built-in drivers suffered bootup hangs with certain
>     driver unregistry sequences, due to sysfs breakage.
>     
>     Do the minimal fix for v2.6.21: only wait if the driver is a module.
>     
>     Acked-by: Ingo Molnar <mingo@...e.hu>
>     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

Linus, please revert this patch.  It merely papers over the fact that
there is a reference count still around that never gets released.  Kay's
patch that Andrew just forwarded to you fixes the real problem, which
other people had noticed and this patch does not fix.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/