linux-kernel - RE: [PATCH 4/4] [SCSI]stex: minor cleanup and version update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <B70A50D07063384EB9BCE3330D18414F0327EBC8@nonameb.ptu.promise.com>
Date:	Mon, 2 Apr 2007 11:21:08 -0700
From:	"Ed Lin" <ed.lin@...mise.com>
To:	"Brian King" <brking@...ibm.com>
Cc:	"linux-scsi" <linux-scsi@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"james.Bottomley" <james.Bottomley@...elEye.com>,
	"jeff" <jeff@...zik.org>,
	"Promise_Linux" <Promise_Linux@...mise.com>
Subject: RE: [PATCH 4/4] [SCSI]stex: minor cleanup and version update



> -----Original Message-----
> From: Brian King [mailto:brking@...ibm.com] 
> Sent: Monday, April 02, 2007 9:05 AM
> To: Ed Lin
> Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; Promise_Linux
> Subject: Re: [PATCH 4/4] [SCSI]stex: minor cleanup and version update
> 
> 
> Ed Lin wrote:
> > @@ -1007,6 +1008,11 @@ static int stex_abort(struct scsi_cmnd *
> >  	u32 data;
> >  	int result = SUCCESS;
> >  	unsigned long flags;
> > +
> > +	printk(KERN_INFO DRV_NAME
> > +		"(%s): aborting command\n", pci_name(hba->pdev));
> > +	scsi_print_command(cmd);
> > +
> 
> scmd_printk is probably what you want here rather than just a printk.
> 
> scmd_printk(KERN_ERR, cmd, "aborting command\n");
> 
> 
> > @@ -1092,6 +1098,10 @@ static int stex_reset(struct scsi_cmnd *
> >  	unsigned long before;
> >  	hba = (struct st_hba *) &cmd->device->host->hostdata[0];
> > 
> > +	printk(KERN_INFO DRV_NAME
> > +		"(%s): resetting host\n", pci_name(hba->pdev));
> > +	scsi_print_command(cmd);
> > +
> 
> Same here.

Well it's just because printk with pci_name stuff is used across
the driver, and I didn't want to break the rule... 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/