linux-kernel - Re: [PATCH 1/4] x86_64: Switch to SPARSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0704021345110.1224@schroedinger.engr.sgi.com>
Date:	Mon, 2 Apr 2007 13:51:41 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Martin Bligh <mbligh@...gle.com>
cc:	Dave Hansen <hansendc@...ibm.com>, Andi Kleen <ak@...e.de>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-mm@...ck.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH 1/4] x86_64: Switch to SPARSE_VIRTUAL

On Mon, 2 Apr 2007, Martin Bligh wrote:

> > Its just the opposite. The vmemmap code is so efficient that we can remove
> > lots of other code and gops of these alternate implementations. On x86_64
> > its even superior to FLATMEM since FLATMEM still needs a memory reference
> > for the mem_map area. So if we make SPARSE standard for all configurations
> > then there is no need anymore for FLATMEM DISCONTIG etc etc. Can we not
> > cleanup all this mess? Get rid of all the gazillions of #ifdefs please? This
> > would ease code maintenance significantly. I hate having to constantly
> > navigate my way through all the alternatives.
> 
> The original plan when this was first merged was pretty much that -
> for sparsemem to replace discontigmem once it was well tested. Seems
> to have got stalled halfway through ;-(

But you made big boboo in SPARSEMEM. Virtual memmap is a textbook case 
that was not covered. Instead this horrible stuff that involves calling 
functions in VM primitives. We could have been there years ago...

> Not sure we'll get away with replacing flatmem for all arches, but
> we could at least get rid of discontigmem, it seems.

I think we could start with x86_64 and ia64. Both will work fine with 
SPARSE VIRTUAL (and SGIs concerns about performance are addressed) and we 
could remove the other alternatives. That is going to throw out lots of 
stuff. Then proceed to other arches

Could the SPARSEMEM folks take this over this patch? You have more 
resources and I am all alone on this. I will post another patchset today 
that also includes an IA64 implementation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/