linux-kernel - RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <B70A50D07063384EB9BCE3330D18414F0327EBFF@nonameb.ptu.promise.com>
Date:	Mon, 2 Apr 2007 16:01:53 -0700
From:	"Ed Lin" <ed.lin@...mise.com>
To:	"James Bottomley" <James.Bottomley@...elEye.com>
Cc:	"linux-scsi" <linux-scsi@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"jeff" <jeff@...zik.org>,
	"Promise_Linux" <Promise_Linux@...mise.com>
Subject: RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device



> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@...elEye.com] 
> Sent: Monday, April 02, 2007 11:28 AM
> To: Ed Lin
> Cc: linux-scsi; linux-kernel; jeff; Promise_Linux
> Subject: RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for 
> console device
> 
> 
> On Mon, 2007-04-02 at 11:14 -0700, Ed Lin wrote:
> > I just saw the routine name scsi_eh_try_stu, and didn't notice the
> > allow_restart (partly because I thought it was not harmful...).
> > But the TEST_UNIT_READY must stay.
> 
> Sure ... I was just checking since your change log implied you'd seen
> the problem from the error handler ... however, we can add it ...
> there's a possibility of getting spin up on init from sd anyway.
> 

You make the decision. But after reconsideration, I think it's better
to remove unused code. It also needs change since the patch about
id mapping is modified in another mail.

How about the attachment here?

Download attachment "s3" of type "application/octet-stream" (893 bytes)