linux-kernel - Re: mcdx -- do_request(): non-read command to cd!!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0704020949160.23099@sbz-30.cs.Helsinki.FI>
Date:	Mon, 2 Apr 2007 09:50:09 +0300 (EEST)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	Rene Herman <rene.herman@...il.com>
cc:	Jens Axboe <jens.axboe@...cle.com>,
	Al Viro <viro@....linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: mcdx -- do_request(): non-read command to cd!!

On Mon, 2 Apr 2007, Rene Herman wrote:
> +       if (!blk_fs_request(req)) {
> +               spin_lock_irq(q->queue_lock);

Contrary to what I said, this spin_lock_irq() is wrong...

> +               end_request(req, 0);
> +               goto again;
> +       }
> +
> +       spin_unlock_irq(q->queue_lock);

...because we drop the lock here.

			Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/