linux-kernel - Re: [PATCH] vt: Do not clear UTF when resetting console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1175559377.7267.13.camel@daplas>
Date:	Tue, 03 Apr 2007 08:16:17 +0800
From:	"Antonino A. Daplas" <adaplas@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andrew Morton <akpm@...l.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Paul LeoNerd Evans <leonerd@...nerd.org.uk>
Subject: Re: [PATCH] vt: Do not clear UTF when resetting console

On Mon, 2007-04-02 at 10:35 -0700, H. Peter Anvin wrote:
> Antonino A. Daplas wrote:
> > Resetting the console, either by ANSI escape sequences or by the reset utility,
> > will drop the console back to legacy (non-UTF-8) mode. Fix this by leaving the
> > field vc_data.vc_utf untouched in reset_terminal(). In addition, a global
> > variable (default_utf8) which defines system-wide UTF-8 setting is created.
> > This variable can be adjusted via sysfs.
> 
> If you're going to introduce a system-wide default, instead of issuing 
> the appropriate escape code, then I would argue it should still be 
> forced (to the default) when issuing a console reset.
> 

That would be the cleanest and purest behavior. But it's possible to set
one console to UTF-8 and another to legacy mode. So one can corrupt the
user's console just by issuing a reset or echo -e '\033c'. (Although one
can argue that users who know what UTF-8 is also knows how to set the
encoding back)

Until userspace is more capable of setting back the terminal to its
previous configuration, I would tend to agree with Jan, that we should
leave the current utf setting of that particular vc alone.

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/