lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 3 Apr 2007 20:34:17 -0400
From:	"Karl Pickett" <karl.pickett@...il.com>
To:	linux-kernel@...r.kernel.org, linux-input@...ey.karlin.mff.cuni.cz,
	dmitry.torokhov@...il.com
Subject: [PATCH] Make ati_remote button repeat sensitivity soft-configurable

The ati_remote driver is a little too sensitive for my wife... if you
do anything but barely tap the button you can get multiple events
reported.  We prefer a more conservative no-repeat setting.  This is a
pretty trivial patch which just makes one hard coded value soft
configurable and does not change the default.

--- linux-source-2.6.20/drivers/usb/input/ati_remote.c.kjp
2006-12-07 22:50:56.000000000 -0500
+++ linux-source-2.6.20/drivers/usb/input/ati_remote.c  2007-04-03
20:19:24.000000000 -0400
@@ -119,7 +119,9 @@
  * and we have to take this into account for an accurate repeat
  * behaviour.
  */
-#define FILTER_TIME    60 /* msec */
+#define FILTER_TIME    60 /* millisec between each repeat */
+
+#define FILTER_MAX     5 /* number of repeats to ignore */

 static unsigned long channel_mask;
 module_param(channel_mask, ulong, 0644);
@@ -133,6 +135,11 @@
 module_param(repeat_filter, int, 0644);
 MODULE_PARM_DESC(repeat_filter, "Repeat filter time, default = 60 msec");

+static int repeat_filter_max = FILTER_MAX;
+module_param(repeat_filter_max, int, 0644);
+MODULE_PARM_DESC(repeat_filter_max,
+       "Number of repeats to ignore, default = 5");
+
 #define dbginfo(dev, format, arg...) do { if (debug) dev_info(dev ,
format , ## arg); } while (0)
 #undef err
 #define err(format, arg...) printk(KERN_ERR format , ## arg)
@@ -515,7 +522,7 @@
                ati_remote->old_jiffies = jiffies;

                if (ati_remote->repeat_count > 0 &&
-                   ati_remote->repeat_count < 5)
+                   ati_remote->repeat_count < repeat_filter_max)
                        return;




-- 
Karl Pickett
The most wasted of all days is one without laughter.—E.E. Cummings
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists