[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 04 Apr 2007 11:16:58 +0100
From: David Howells <dhowells@...hat.com>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-arch@...r.kernel.org,
Linux Memory Management <linux-mm@...ck.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu)
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> - if (!(flags & MAP_SHARED))
> + /* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu
> + * folks there... --BenH.
> + */
> + if ((flags & MAP_FIXED) || !(flags & MAP_SHARED))
MAP_FIXED on NOMMU? Surely you jest...
See the first if-statement in validate_mmap_request().
If anything, you should be adding BUG_ON(flags & MAP_FIXED).
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists