linux-kernel - Re: [PATCH] blackfin arch: use boot_command_line instead of save_command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Apr 2007 08:07:52 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	bryan.wu@...log.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blackfin arch: use boot_command_line instead of
 save_command_line in setup c file

On Wed, 04 Apr 2007 14:28:23 +0800 Wu, Bryan wrote:

> 
> Signed-off-by: Bryan Wu <bryan.wu@...log.com>
> ---
>  arch/blackfin/kernel/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
> index ce51882..9870c60 100644
> --- a/arch/blackfin/kernel/setup.c
> +++ b/arch/blackfin/kernel/setup.c
> @@ -221,7 +221,7 @@ void __init setup_arch(char **cmdline_p)
>  
>  	/* Keep a copy of command line */
>  	*cmdline_p = &command_line[0];
> -	memcpy(saved_command_line, command_line, COMMAND_LINE_SIZE);
> +	memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
>  	saved_command_line[COMMAND_LINE_SIZE - 1] = 0;
>  
>  	/* setup memory defaults from the user config */
> -- 

Hi Bryan,

Patch descriptions should include _why_ a change is being made,
not just what the change is.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/