linux-kernel - Re: [S390] page_mkclean data corruption.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2007 22:14:04 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [S390] page_mkclean data corruption.


> > ---
> >  mm/rmap.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/mm/rmap.c b/mm/rmap.c
> > index 22ed3f7..b82146e 100644
> > --- a/mm/rmap.c
> > +++ b/mm/rmap.c
> > @@ -498,9 +498,9 @@ int page_mkclean(struct page *page)
> >  		struct address_space *mapping = page_mapping(page);
> >  		if (mapping)
> >  			ret = page_mkclean_file(mapping, page);
> > +		if (page_test_and_clear_dirty(page))
> > +			ret = 1;
> >  	}
> > -	if (page_test_and_clear_dirty(page))
> > -		ret = 1;
> >  
> >  	return ret;
> >  }
> 
> This changes generic mm code. Is S390 really the only affected architecture?

Yeah, its the only arch where page_test_and_clear_dirty() is not 0

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/