linux-kernel - Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Apr 2007 22:36:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, tglx@...utronix.de,
	johnstul@...ibm.com, LKML <linux-kernel@...r.kernel.org>,
	heiko.carstens@...ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree


* Daniel Walker <dwalker@...sta.com> wrote:

> The struct clocksource .list field is now required to be initialized 
> before calling clocksource_register().
> 
> This is a prerequisite for simplifying the clocksource registration 
> process.

why? This patch only pushes some unnecessary code into the clocksource 
drivers:

+       .list           = LIST_HEAD_INIT(clocksource_avr32.list),

NACK unless you can give an explanation of why this is unavoidable. A 
NULL initializer is just as good as an initialized list entry. (in fact 
it's slightly better because it's in the kernel's BSS)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/