linux-kernel - Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Apr 2007 23:34:04 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, tglx@...utronix.de,
	johnstul@...ibm.com, LKML <linux-kernel@...r.kernel.org>,
	heiko.carstens@...ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree


* Daniel Walker <dwalker@...sta.com> wrote:

> > but why do you call that a simplification? Remove 5 lines of code 
> > from the generic code, by adding +1 line to every clocksource 
> > driver, totalling to like +20 lines at the moment?
> 
> I guess I don't look at it in terms of lines .. Why do you think 
> reciting a line count diminishes the "simplification" claim? The 20+ 
> lines that I added to each clocksource don't have a size or runtime 
> effect ..

but they have a robustness and maintainability effect. Key is to keep 
drivers _simple_ and hard to mess up. If it's 5 extra lines of code to 
simplify a driver then we just do it. This is maintainance 101.

i cannot believe you are still arguing this. I explained this to you 
many weeks ago!

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/