linux-kernel - Re: Performance Stats: Kernel patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2007 17:54:32 -0400
From:	Valdis.Kletnieks@...edu
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Maxim Uvarov <muvarov@...mvista.com>, linux-kernel@...r.kernel.org
Subject: Re: Performance Stats: Kernel patch

On Wed, 04 Apr 2007 15:46:24 +0200, Eric Dumazet said:
> On Wed, 04 Apr 2007 17:15:43 +0400
> Maxim Uvarov <muvarov@...mvista.com> wrote:

> > +#ifdef CONFIG_THREAD_PERF_STAT_SYSC
> > +       call inc_syscallcnt             # Increment syscalls counter 
> > current->sysc_cnt
> > +#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
> 
> Please dont call a function to do one increment !
> 
> You are touching one of the most critical part of the kernel...

Obviously Eric and I looked at this looking for totally different things. :)

Thanks for spotting that, I totally failed to notice that part....


Content of type "application/pgp-signature" skipped