linux-kernel - Re: [patch 1/2] Relocate VDSO ELF headers to match mapped location with COMPAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070405063152.9227D180064@magilla.sf.frob.com>
Date:	Wed,  4 Apr 2007 23:31:52 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
	virtualization@...ts.osdl.org, lkml <linux-kernel@...r.kernel.org>,
	Zachary Amsden <zach@...are.com>,
	"Jan Beulich" <JBeulich@...ell.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [patch 1/2] Relocate VDSO ELF headers to match mapped location with COMPAT_VDSO

The patch looks nice and clean.  However, it does not relocate the symbol
table(s) values.  I thought that was done in an earlier version of this I
saw, but I might be misremembering.  Though not fatal, this is a regression
from the previous CONFIG_COMPAT_VDSO behavior.  It will show up in things
like __kernel_* name display in backtraces.  If with your other patch
CONFIG_COMPAT_VDSO will become other than a rarely-used compatibility
option, then this should be fixed.  Note that with your second patch this
will also break the symbol values in the randomly-located vma vdso;
non-ancient glibc doesn't care if the vdso isn't mapped where its phdrs
say, but everything does still care that the symbol tables in an ELF file
use addresses matching the phdrs in the same file.

Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/