linux-kernel - [patch 2/2] only allow nonlinear vmas for ram backed filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1HZOIr-0000Rv-00@dorka.pomaz.szeredi.hu>
Date:	Thu, 05 Apr 2007 11:30:49 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	akpm@...ux-foundation.org
CC:	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: [patch 2/2] only allow nonlinear vmas for ram backed filesystems

From: Miklos Szeredi <mszeredi@...e.cz>

page_mkclean() doesn't re-protect ptes for non-linear mappings, so a
later re-dirty through such a mapping will not generate a fault,
PG_dirty will not reflect the dirty state and the dirty count will be
skewed.  This implies that msync() is also currently broken for
nonlinear mappings.

Peter Zijlstra writes:
> In order to make page_mkclean() work for nonlinear vmas we need to do a
> full pte scan for each invocation (we could perhaps only scan 1 in n
> times to try and limit the damage) and that hurts. This will basically
> render it useless.
> 
> The other solution is adding rmap information to nonlinear vmas but
> doubling the memory overhead for nonlinear mappings was not deemed a
> good idea.

The easiest solution is to emulate remap_file_pages on non-linear
mappings with simple mmap() for non ram-backed filesystems.
Applications continue to work (albeit slower), as long as the number
of remappings remain below the maximum vma count.

However all currently known real uses of non-linear mappings are for
ram backed filesystems, which this patch doesn't affect.

William Lee Irwin III writes:
> It's used for > 3GB files on tmpfs and also ramfs, sometimes
> substantially larger than 3GB.
> 
> It's not used for the database proper. It's used for the buffer pool,
> which is the in-core destination and source of direct I/O, the on-disk
> source and destination of the I/O being the database.

Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
---

Index: linux/mm/fremap.c
===================================================================
--- linux.orig/mm/fremap.c	2007-04-05 11:18:21.000000000 +0200
+++ linux/mm/fremap.c	2007-04-05 11:18:25.000000000 +0200
@@ -181,6 +181,24 @@ asmlinkage long sys_remap_file_pages(uns
 			goto retry;
 		}
 		mapping = vma->vm_file->f_mapping;
+		/*
+		 * page_mkclean doesn't work on nonlinear vmas, so if dirty
+		 * pages need to be accounted, emulate with linear vmas.
+		 */
+		if (mapping_cap_account_dirty(mapping)) {
+			unsigned long addr;
+
+			flags &= MAP_NONBLOCK;
+			addr = mmap_region(vma->vm_file, start, size, flags,
+					   vma->vm_flags, pgoff, 1);
+			if (IS_ERR_VALUE(addr))
+				err = addr;
+			else {
+				BUG_ON(addr != start);
+				err = 0;
+			}
+			goto out;
+		}
 		spin_lock(&mapping->i_mmap_lock);
 		flush_dcache_mmap_lock(mapping);
 		vma->vm_flags |= VM_NONLINEAR;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/