linux-kernel - Re: [PATCH] HPA support: Revised patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070405192421.GB5131@lug-owl.de>
Date:	Thu, 5 Apr 2007 21:24:21 +0200
From:	Jan-Benedict Glaw <jbglaw@...-owl.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	akpm@...l.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, kyle@...onical.com
Subject: Re: [PATCH] HPA support: Revised patch

On Thu, 2007-04-05 14:13:52 +0100, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c	2007-04-03 16:56:32.000000000 +0100
> +++ linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c	2007-04-03 17:08:28.000000000 +0100
> @@ -90,6 +90,10 @@
>  module_param_named(fua, libata_fua, int, 0444);
>  MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on)");
>  
> +static int ata_ignore_hpa = 0;
> +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
> +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)");
> +
>  static int ata_probe_timeout = ATA_TMOUT_INTERNAL / HZ;
>  module_param(ata_probe_timeout, int, 0444);
>  MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout (seconds)");

For ignore_hpa, it would be nice to not go through inverse logic and
fix the help text a bit (0=honor HPA, 1=ignore HPA).

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@...-owl.de              +49-172-7608481
Signature of:            http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
the second  :

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)