linux-kernel - Re: What protects cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46156548.6080102@goop.org>
Date:	Thu, 05 Apr 2007 14:08:24 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andi Kleen <ak@...e.de>
CC:	Benjamin LaHaise <bcrl@...ck.org>, Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: What protects cpu_tlbstate?

Andi Kleen wrote:
>> Hm, I was more wondering about simple compiler reordering.  Does the
>> relative order of setting and reading cpu_tlbstate.state, active_mm and
>> the mm->cpu_vm_mask matter?
>>     
>
> Hmm, perhaps a barrier between state and active_mm might be a good idea.
> Setting active_mm after state might be problematic.
> cpu_vm_mask should be already a memory barrier.
>   

Should leave_mm update active_mm and set the state to TLBSTATE_OK?  Just
reloading cr3 seems a bit blunt.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/