linux-kernel - Re: 2.6.21-rc5-mm4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1r6qx8tf3.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 06 Apr 2007 08:32:48 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jiri Kosina <jikos@...os.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	Len Brown <len.brown@...el.com>,
	Natalie Protasevich <nataliep@...gle.com>,
	Andi Kleen <ak@...e.de>,
	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	auke-jan.h.kok@...el.com
Subject: Re: 2.6.21-rc5-mm4

Jiri Kosina <jikos@...os.cz> writes:

> Hi Eric,
>
> after struggling with this issue for some time, I think that it's just 
> some incosistent usage of NR_IRQS throughout the source probably due to 
> some include hell. I really don't understand the how the mach-*/ includes 
> are supposed to work.
>
> I found out (by disassembling resulting vmlinux binaries) that in 
> arch/i386/kernel/entry.S, the loop in irq_entries_start does too little 
> iterations compared to NR_IRQS value as seen in for example io_apic.c
>
> The super-stupid proof-patch below fixes the panic on my system. It's just 
> to demonstrate that the i386 includes really need fixing to be consistent 
> somehow.

Thanks, and that would do it, it  makes sense why it was the irq patch
that caused problems.  I had forgotten about the number of stubs issue.

I had to clean that up on x86_64 as well and it probably makes most sense
to put that cleanup as well, so we have a small fixed number of stubs
which would make the includes not matter.

Bleh.  Hopefully soon.

Eric

> diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
> index 976438c..b20dc07 100644
> --- a/arch/i386/kernel/entry.S
> +++ b/arch/i386/kernel/entry.S
> @@ -53,6 +53,8 @@
>  #include <asm/dwarf2.h>
>  #include "irq_vectors.h"
>  
> +#define NR_IRQS 4096
> +
>  /*
>   * We use macros for low-level operations which need to be overridden
>   * for paravirtualization.  The following will never clobber any registers:
>
> -- 
> Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/