linux-kernel - Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704061557.12662.david-b@pacbell.net>
Date:	Fri, 6 Apr 2007 15:57:12 -0700
From:	David Brownell <david-b@...bell.net>
To:	tglx@...utronix.de
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote:
> David,
> 
> http://tglx.de/private/tglx/usbnet.png
> 
> /me recommends emacs-develock.el for colorful white space wreckage
> display !

Then I'd have to switch to EMACS ... no thanks!  ;)

At the risk of switching to a VI/EMACS flamewar (could that be
an improvement?) "let c_space_errors=1" shows the same sort of
thing ... albeit a bit more usefully, it just highlights the
single useless space character at the beginning of that line.
(Which starts "space-TAB-TAB-TAB".)

> You probably want to look at more files contributed by david-b before
> you look at mine :)

I last touched that header in 2005 ... next time I have reason to
touch it, I'll likely fix that little thing!   Patches accepted.  :)

This particular issue doesn't actually affect indentation, since the
tab trumps that space.  So it's a bit off-agenda for this particular
flamage.  I tend to fix such space errors whenever I trip over them;
e.g. "git show 438d6c2c015cf63bf7e9bdc2033d435433ac8455".

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/