linux-kernel - Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704061634.39344.david-b@pacbell.net>
Date:	Fri, 6 Apr 2007 16:34:38 -0700
From:	David Brownell <david-b@...bell.net>
To:	tglx@...utronix.de
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

On Friday 06 April 2007 4:21 pm, Thomas Gleixner wrote:
> David,
> 
> On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote:
> > This particular issue doesn't actually affect indentation, since the
> > tab trumps that space.  So it's a bit off-agenda for this particular
> > flamage.
> 
> ROTFL, the tab trumps the space. Is this a card game ?

Nah, just standard display algorithms.  Alignment doesn't change.


> > > Please change your coding style to conform to Documentation/CodingStyle.
> > > 
> > >       ***     Only indent with tabs!!         ***
> 
> How does your own rule make SPACE-TAB-TAB more acceptable than
> TAB-TAB-SPACE ? Just because TAB trumps the space but not the other way
> round ?

Because when you display the text, it doesn't affect the
alignment == indentation.  In fact you have to turn on
nonstandard editor options to even see if this happened.
Not everyone does so, which is why such things persist.

So in practical terms "\n \t" and "\n\t" are identical;
although the former "should not" be used, it doesn't
actually affect what CodingStyle is primarily trying to
control (i.e. what the code looks like).


> You started nitpicking, so please accept the backfire.

Done.

:)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/