linux-kernel - Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6599ad830704071030s3887ded2r5597e19507cb556f@mail.gmail.com>
Date:	Sat, 7 Apr 2007 10:30:27 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	vatsa@...ibm.com
Cc:	akpm@...ux-foundation.org, sekharan@...ibm.com, dev@...ru,
	xemul@...ru, serue@...ibm.com, ebiederm@...ssion.com,
	ckrm-tech@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	containers@...ts.osdl.org, mbligh@...gle.com, rohitseth@...gle.com,
	devel@...nvz.org
Subject: Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

On 4/6/07, Srivatsa Vaddagiri <vatsa@...ibm.com> wrote:
> On Fri, Apr 06, 2007 at 04:32:24PM -0700, menage@...gle.com wrote:
> > +static int attach_task(struct container *cont, struct task_struct *tsk)
> >  {
>
> [snip]
>
> > +     task_lock(tsk);
>
> You need to check here if task state is PF_EXITING and fail with
> -ESRCH if so? Otherwise we risk breaking refcount on
> init_container_group.
>

Yes, I think you're right; I've now changed it to this in my tree:

        task_lock(tsk);
        if (tsk->flags & PF_EXITING) {
                task_unlock(tsk);
                put_container_group(newcg);
                return -ESRCH;
        }
        rcu_assign_pointer(tsk->containers, newcg);
        task_unlock(tsk);

Thanks,

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/