linux-kernel - Re: [RFC] pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070408210917.6e306851@the-village.bc.nu>
Date:	Sun, 8 Apr 2007 21:09:17 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Garzik <jgarzik@...ox.com>
Subject: Re: [RFC] pata_icside driver

> +	/*
> +	 * DMA is based on a 16MHz clock
> +	 */
> +	if (ata_timing_compute(adev, adev->dma_mode, &t, 1000, 1))
> +		return;

This seems strange for a 16MHz clock.

> +
> +	/*
> +	 * Now, properly adjust the timings.  If we have a 62.5ns clock
> +	 * period and we ask for MWDMA2, it calculates the following
> +	 * timings: active 125ns, recovery 62.5ns, cycle 125ns.
> +	 * Quite obviously bogus. 

NAK. 

At this point you need to work out why you are getting bogus results and
fix it or demonstrate a bug in the core code and fix that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/