linux-kernel - Re: coding style for long conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704090814.18137.david-b@pacbell.net>
Date:	Mon, 9 Apr 2007 08:14:17 -0700
From:	David Brownell <david-b@...bell.net>
To:	Junio C Hamano <junkio@....net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: coding style for long conditions

> > So in practical terms "\n \t" and "\n\t" are identical;
> > although the former "should not" be used, it doesn't
> > actually affect what CodingStyle is primarily trying to
> > control (i.e. what the code looks like).
> 
> That's not what CodingStyle is trying to control.  Not "what the
> code looks like" at all.

That's news to many folk.  "What the code looks like" has always
been the fundamental reason to have coding conventions.  If you
look at coding convention documents over the last fifty years or
so you will notice that's what they're about ... even back in the
days when "text" came on punched cards or line printer output.

The "extraneous hidden whitespace" stuff is sort of a new issue.
I happened across a discussion of it on the GCC list last month ...
it's a meme that wasn't widespread even five years ago.

That "get a decent editor" thing is because some editors are so deeply
broken that they think it's actually OK to replace tabs with whitespace,
or automatically add extraneous whitespace.  Also, because some emailer
tools do the same thing.  (Yet another reason to dislike Microsoft, sigh.)

Secondarily, it's also because having "hidden" spaces can cause hassles
when maintaining code.

Me, i've always been offended by all the wasted disk space, but I think
I'm a minority there.  ;)

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/