linux-kernel - Re: [PATCH 1/2] Clean up asm-x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070409084557.28748317.randy.dunlap@oracle.com>
Date:	Mon, 9 Apr 2007 08:45:57 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andrew Morton <akpm@...l.org>, Andi Kleen <ak@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Virtualization Mailing List <virtualization@...ts.osdl.org>
Subject: Re: [PATCH 1/2] Clean up asm-x86_64/bugs.h

On Sat, 07 Apr 2007 10:22:01 -0700 Jeremy Fitzhardinge wrote:

> Most of asm-x86_64/bugs.h is code which should be in a C file, so put it there.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy@...source.com>
> Cc: Andi Kleen <ak@...e.de>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> 
> ---
>  arch/x86_64/kernel/Makefile      |    3 ++-
>  arch/x86_64/kernel/bugs.c        |   28 ++++++++++++++++++++++++++++
>  include/asm-x86_64/alternative.h |    1 +
>  include/asm-x86_64/bugs.h        |   30 ++++--------------------------
>  4 files changed, 35 insertions(+), 27 deletions(-)
> 
> ===================================================================
> --- /dev/null
> +++ b/arch/x86_64/kernel/bugs.c
> @@ -0,0 +1,28 @@
> +/*
> + *  arch/x86_64/kernel/bugs.c
> + *
> + *  Copyright (C) 1994  Linus Torvalds
> + *  Copyright (C) 2000  SuSE
> + *
> + * This is included by init/main.c to check for architecture-dependent bugs.

drop comment.

Are you going to tackle asm-i386/bugs.h also?

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/