linux-kernel - Re: [PATCH]: Resubmit Fix overloaded use of acpi= on bootline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070409085920.2a467912.randy.dunlap@oracle.com>
Date:	Mon, 9 Apr 2007 08:59:20 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, mingo@...hat.com
Subject: Re: [PATCH]: Resubmit Fix overloaded use of acpi= on bootline

On Mon, 9 Apr 2007 09:25:47 -0400 Prarit Bhargava wrote:

> The use of "apic=" on the boot line is overloaded.  It is used once to
> override the type of genapic, and then later on it is used to determine a debug
> level.  Because of this a bogus error message is sent to the console when using
> the debug option:
> 
> 	Unknown genapic `apic=debug' specified.
> 
> This patch changes the genapic situation to use "genapic=".
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>

Thanks, looks good except that the Subject line could confuse
someone (s/acpi/apic/).


> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index ef2ffde..8cbd90c 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -589,6 +589,9 @@ and is between 256 and 4096 characters. It is defined in the file
>  
>  	gamma=		[HW,DRM]
>  
> +	genapic=	[APIC,i386] Select a specific genapic type to be used.
> +			Format: <name>
> +
>  	gdth=		[HW,SCSI]
>  			See header of drivers/scsi/gdth.c.
>  
> diff --git a/arch/i386/mach-generic/probe.c b/arch/i386/mach-generic/probe.c
> index a7b3999..cabe31b 100644
> --- a/arch/i386/mach-generic/probe.c
> +++ b/arch/i386/mach-generic/probe.c
> @@ -49,7 +49,7 @@ static int __init parse_apic(char *arg)
>  	/* Parsed again by __setup for debug/verbose */
>  	return 0;
>  }
> -early_param("apic", parse_apic);
> +early_param("genapic", parse_apic);
>  
>  void __init generic_bigsmp_probe(void)
>  {
> -


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/