linux-kernel - Re: [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Apr 2007 11:12:17 +0200
From:	Andi Kleen <ak@...e.de>
To:	David Miller <davem@...emloft.net>
Cc:	hch@...radead.org, ashok.raj@...el.com,
	linux-kernel@...r.kernel.org, akpm@...l.org, gregkh@...e.de,
	muli@...ibm.com, asit.k.mallick@...el.com,
	suresh.b.siddha@...el.com, anil.s.keshavamurthy@...el.com,
	arjan@...ux.intel.com, shaohua.li@...el.com
Subject: Re: [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map

On Tuesday 10 April 2007 11:07:02 David Miller wrote:
> From: Christoph Hellwig <hch@...radead.org>
> Date: Tue, 10 Apr 2007 09:33:51 +0100
> 
> > On Mon, Apr 09, 2007 at 02:55:57PM -0700, Ashok Raj wrote:
> > > Most GFX drivers don't call standard PCI DMA APIs to allocate DMA buffer,
> > > Such drivers will be broken with IOMMU enabled. To workaround this issue, 
> > > we added two options.
> > 
> > All drm drivers do it.  If the usual out of tree crap vendors are too
> > stupid for their own sake it's their fault.
> > 
> > So NACK to this patch.
> 
> That's my feeling as well, everything we care about should be using
> the proper APIs or else what is the point of them...

They can't. There is no proper API to do IOMMU mappings from user space.
And that is how Xorg on x86 works.

I had some hackish patches to enable mapping on /sys/bus/pci/.../coherent_mem, but
you need ioctls to pass out the translated address and it wasn't
exactly pretty. Still also not sure that's the right way.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/