linux-kernel - Re: [PATCH 9/10] Vmi timer update.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Apr 2007 15:28:44 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Zachary Amsden <zach@...are.com>
Cc:	Chris Wright <chrisw@...s-sol.org>, Andrew Morton <akpm@...l.org>,
	Andi Kleen <ak@....de>, Thomas Gleixner <tglx@...utronix.de>,
	Virtualization Mailing List <virtualization@...ts.osdl.org>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/10] Vmi timer update.patch

* Zachary Amsden (zach@...are.com) wrote:
> Yes, but unfortunately that is a nop:
> 
>         /*
>          * Avoid unnecessary state transitions, as it confuses
>          * Geode / Cyrix based boxen.
>          */
>         case CLOCK_EVT_MODE_SHUTDOWN:
>                 if (evt->mode == CLOCK_EVT_MODE_UNUSED)
>                         break;
>         case CLOCK_EVT_MODE_UNUSED:
>                 if (evt->mode == CLOCK_EVT_MODE_SHUTDOWN)
>                         break;

This one should be fallthrough case during exchange (mode == PERIODIC)

>         case CLOCK_EVT_MODE_ONESHOT:
>                 /* One shot setup */
>                 outb_p(0x38, PIT_MODE);
> 
> So switching from PIT to VMI does not disable PIT timer interrupts.  
> Thus I have to keep this part of the patch.

Oh, I was looking at this (x86_64 work I have here):

	case CLOCK_EVT_MODE_SHUTDOWN:
	case CLOCK_EVT_MODE_UNUSED:
		outb_p(0x30, PIT_MODE);
		outb_p(0, PIT_CH0);	/* LSB */
		outb_p(0, PIT_CH0);	/* MSB */
		break;

That's mode 0, not mode 5, but I think the end result is the same.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/