linux-kernel - Re: [-mm3 PATCH] (Retry) Check the return value of kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070411001929.5162cf41.akpm@linux-foundation.org>
Date:	Wed, 11 Apr 2007 00:19:29 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and
 etc.

On Wed, 11 Apr 2007 14:45:25 +0800 WANG Cong <xiyou.wangcong@...il.com> wrote:

> >-		snprintf(p->kobj.name,KOBJ_NAME_LEN,"%sp%d",disk->kobj.name,part);
> >+		snprintf(p->kobj.name, KOBJ_NAME_LEN, "%sp%d",
> >+				disk->kobj.name, part);
>                                                ^^^
> Andrew, it seems that you left an additional whitespace in the above line (marked as ^^^).
> 
> > 	else
> >-		snprintf(p->kobj.name,KOBJ_NAME_LEN,"%s%d",disk->kobj.name,part);
> >+		snprintf(p->kobj.name, KOBJ_NAME_LEN, "%s%d",
> >+				disk->kobj.name, part);
>                                                ^^^
> Also here. ;-p

Those are known as "fixes" ;)

One shouldn't mix whitespace fixes with functional changes really, but I
can't help myself.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/