linux-kernel - Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6599ad830704110142yf00e878n97b4162ebbeee5d@mail.gmail.com>
Date:	Wed, 11 Apr 2007 01:42:54 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	vatsa@...ibm.com
Cc:	akpm@...ux-foundation.org, sekharan@...ibm.com, dev@...ru,
	xemul@...ru, serue@...ibm.com, ebiederm@...ssion.com,
	ckrm-tech@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	containers@...ts.osdl.org, mbligh@...gle.com, rohitseth@...gle.com,
	devel@...nvz.org
Subject: Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

On 4/10/07, Srivatsa Vaddagiri <vatsa@...ibm.com> wrote:
> [ Sorry abt piece meal reviews, I am sending comments as and when I spot
> something ]

That's no problem.

>
> On Fri, Apr 06, 2007 at 04:32:24PM -0700, menage@...gle.com wrote:
> > -void container_exit(struct task_struct *tsk)
> > +void container_exit(struct task_struct *tsk, int run_callbacks)
> >  {
>
> [snip]
>
> > +     /* Reassign the task to the init_container_group. */
> >       task_lock(tsk);
>
> [snip]
>
> > +     if (tsk->containers != &init_container_group) {
>
> Is this check needed? If we have the check, then:
>
> > +     task_unlock(tsk);
> > +     if (cg)
> > +             put_container_group(cg);
>
> init_container_group refcount is leaky (fork increments it, but exit
> doesnt). Not a big prob perhaps, but ..would be nice to avoid?
>

Yes, I think you're right - over a long uptime that would just cause
problems ...

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/