linux-kernel - Re: [PATCH 2/2] NET: Multiqueue network device support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1HbaOV-0004rc-00@gondolin.me.apana.org.au>
Date:	Wed, 11 Apr 2007 20:49:43 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	peter.p.waskiewicz.jr@...el.com (Waskiewicz Jr, Peter P)
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, jgarzik@...ox.com, cramerj@...el.com,
	auke-jan.h.kok@...el.com, christopher.leech@...el.com
Subject: Re: [PATCH 2/2] NET: Multiqueue network device support.

Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@...el.com> wrote:
> 
> True, but the assignment for "dev" above also casts this void * to
> struct net_device *:
> 
>        dev = (struct net_device *)
>                (((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST);
>        dev->padded = (char *)dev - (char *)p;
> 
> Shall I remove my cast?

This is totally different as it's casting a "long", not a "void *".

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/