linux-kernel - Re: [patch] high-res timers: UP resume fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070411140058.GA5014@ucw.cz>
Date:	Wed, 11 Apr 2007 14:00:58 +0000
From:	Pavel Machek <pavel@....cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	tglx@...utronix.de, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Soeren Sonnenburg <kernel@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Len Brown <len.brown@...el.com>
Subject: Re: [patch] high-res timers: UP resume fix

Hi!

> > > > [...] Soeren, can you confirm that you are using a !CONFIG_SMP kernel, 
> > > > and if yes, does the patch below fix the resume problem for you?
> > > 
> > > hm, you seem to have a CONFIG_SMP=y kernel. I dont immediately see where 
> > > we re-enable interrupts in the SMP case, but could you try my patch 
> > > nevertheless
> > 
> > We do in on_each_cpu() unconditionally. I missed that.
> 
> BTW, the on_each_cpu() in clock_was_set() is unnecessary, because
> timekeeping_resume() is always run on one CPU.

I wonder if we should add BUG_ON(interrupts_enabled) just before
enabling interrupts to catch similar mistakes early?

							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/