linux-kernel - Re: [PATCH] console UTF-8 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461D2AB8.5080902@zytor.com>
Date:	Wed, 11 Apr 2007 11:36:40 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Egmont Koblinger <egmont@...linux.hu>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] console UTF-8 fixes

Egmont Koblinger wrote:
> +static int is_zero_width(long ucs)
> +{
> +  static const struct interval zero_width[] = {
/* lots */
> +  };

I'm still unhappy about these large search tables in the kernel, not 
because they take a huge amount of space (it's not that much), but 
because they're invariably going to be stale, as they're Unicode-version 
dependent.

At least please put them in a separate .c file and include a script to 
generate them clean from UnicodeData.txt.

Besides, would it not make more sense to have a single table with the 
width information, if you insist on having one, instead of multiple ones?

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/