linux-kernel - Re: [PATCH 1/1] ACPI: asus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461D45CE.3030309@gmail.com>
Date:	Wed, 11 Apr 2007 22:32:14 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, corentincj@...aif.net,
	sziwan@...rs.sourceforge.net, acpi4asus-user@...ts.sourceforge.net,
	len.brown@...el.com, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

Andrew Morton napsal(a):
> On Wed, 11 Apr 2007 15:04:35 +0200 (CEST)
> Jiri Slaby <jirislaby@...il.com> wrote:
> 
>> @@ -706,6 +718,8 @@ static int get_lcd_state(void)
>>  {
>>  	int lcd = 0;
>>  
>> +	BUG_ON(!hotk->methods->lcd_status);
> 
> mutter.  We could just warn-and-bale here.
> 
> Hopefully this is just an is-jiri-sane assertion and it should never happen,
> no matter how busted the BIOS tables are?

Exactly :). Only if somebody changes the code around, so that it is called
with the method unset, it triggers and in that case it's definitely a bug.

Side note, as Danny wrote, there is an asus-laptop driver sitting in -mm,
which supersedes this one -- if you plan to push it upstream in the near
future, don't bother with this patch.

thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
 B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/