linux-kernel - Re: Performance Stats: Kernel patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461E383B.6030905@ru.mvista.com>
Date:	Thu, 12 Apr 2007 17:46:35 +0400
From:	Maxim Uvarov <muvarov@...mvista.com>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	linux-kernel@...r.kernel.org, davidsen@....com,
	randy.dunlap@...cle.com, Valdis.Kletnieks@...edu,
	jesper.juhl@...il.com
Subject: Re: Performance Stats: Kernel patch

Eric Dumazet wrote:

> [snip]
> What I meant is : You falsely speak of 'PROCESS performance statistics'.
>
> Your implementation only cares about threads, not processes.
> There is a slight difference, that getrusage() can do.
>
> So if you do "cat /proc/PID/status", you'll get counters not for the 
> PROCESS, only the main thread of the process.
>
> If you want an analogy, imagine a "ps aux" that doesnt show the cpu 
> time of all threads of a process, but only the cpu time of the main 
> thread. Quite meaningless isnt it ?
>
> So either :
>
> 1) You change all your description to mention 'thread' instead of 
> 'process'.
>
> 2) You change your implementation to match your claim.


Thanks again Eric, very useful notes. 

Important information is per-thread counters. So I changed only description.
Seems no issues now?

Patch is attached.

Best regards,
Maxim.

View attachment "perf_stat.patch" of type "text/plain" (10125 bytes)