| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Apr 2007 09:38:15 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Neil Brown <neilb@...e.de>
cc: linux-kernel@...r.kernel.org
Subject: Re: SLUB: kmem_cache_destroy doesn't
On Thu, 12 Apr 2007, Neil Brown wrote:
> And
>
> # cat /sys/slab/raid5-md1/aliases
> -1
>
> is a bit suspicious.
Yuck!
> void kmem_cache_destroy(struct kmem_cache *s)
> {
> down_write(&slub_lock);
> if (s->refcount)
> s->refcount--;
> else {
> list_del(&s->list);
> WARN_ON(kmem_cache_close(s));
> sysfs_slab_remove(s);
> kfree(s);
> }
> up_write(&slub_lock);
> }
>
> looks a bit odd.
> I would have thought the test should be:
>
> if (s->refcount > 1)
Correct. Does the change fix it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists