linux-kernel - Re: [PATCH] console UTF-8 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Apr 2007 09:58:38 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Egmont Koblinger <egmont@...linux.hu>
CC:	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] console UTF-8 fixes

Egmont Koblinger wrote:
> 
> We've arrived at another coding policy :)
> 
> There are two possible behaviors, each have pros and cons. HPA prefers one,
> while Jan and me would prefer the other. The difference is one function that
> contains a large table and an invocation of that function in a small if
> branch.
> 
> In my latest version of the patch I've put the function itself inside
> comments too. So it's not the real compiler, it's the preprocessor that
> omits this code for the default behavior. HPA, I hope you don't mind if the
> other reasonable behavior is there in the source, within comments. I think
> let's make the job easier for those who have a different opinion. Or is it a
> completely stupid idea?
> 

Not leaving dead code in the kernel is long-standing policy; it's 
nothing new.  We constantly remove #if 0'd code that the authors have 
left in.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/