linux-kernel - Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461E6F5F.1030008@goop.org>
Date:	Thu, 12 Apr 2007 10:41:51 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andi Kleen <ak@...ell.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Daniel Walker <dwalker@...sta.com>,
	linux-kernel@...r.kernel.org, johnstul@...ibm.com,
	tglx@...utronix.de
Subject: Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

Andi Kleen wrote:
> Ok. I think it's better to just fix sched_clock() again than to
> add another one.  I can probably
> eliminate the ktime_get() and use something based on jiffies. That will
> be inaccurate for the instable case of course.
>
> I will do that later today.

sched_clock seems a bit weird to use.  In the pv_ops world, it only
counts unstolen time, and it is therefore inherently per-cpu.  The
timestamps should be at least system-wide monotonic.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/