linux-kernel - Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c49b0ed0704121129h51f852a1wbdc3192c89aec4e6@mail.gmail.com>
Date:	Thu, 12 Apr 2007 11:29:21 -0700
From:	"Nate Diller" <nate.diller@...il.com>
To:	"Phillip Lougher" <phillip@...gher.demon.co.uk>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"David Woodhouse" <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

On 4/12/07, Phillip Lougher <phillip@...gher.demon.co.uk> wrote:
> Nate Diller wrote:
>
> > +     page = read_cache_page(OFNI_EDONI_2SFFJ(f)->i_mapping,
> > +                             start >> PAGE_CACHE_SHIFT,
> > +                             (void *)jffs2_do_readpage_unlock,
> > +                             OFNI_EDONI_2SFFJ(f));
> >
> > -     if (IS_ERR(pg_ptr)) {
> > +     if (IS_ERR(page)) {
> >               printk(KERN_WARNING "read_cache_page() returned error: %ld\n", PTR_ERR(pg_ptr));
>
> should be
>
>                 printk(KERN_WARNING "read_cache_page() returned error: %ld\n", PTR_ERR(page));
>
> > -             return PTR_ERR(pg_ptr);
> > +             return PTR_ERR(page);
>

wow, you're right.  I was sure I compile-tested this ... oh, "depends
on MTD".  oops.

thanks for reviewing.  does it look OK to you otherwise?

NATE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/