linux-kernel - Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c49b0ed0704121227h48c3271bp2511e082704d639f@mail.gmail.com>
Date:	Thu, 12 Apr 2007 12:27:07 -0700
From:	"Nate Diller" <nate.diller@...il.com>
To:	"David Howells" <dhowells@...hat.com>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Alexander Viro" <viro@...iv.linux.org.uk>,
	"Christoph Hellwig" <hch@...radead.org>,
	"Roman Zippel" <zippel@...ux-m68k.org>,
	"Mikulas Patocka" <mikulas@...ax.karlin.mff.cuni.cz>,
	"David Woodhouse" <dwmw2@...radead.org>,
	"Dave Kleikamp" <shaggy@...tin.ibm.com>,
	"Anton Altaparmakov" <aia21@...tab.net>,
	"Evgeniy Dushistov" <dushistov@...l.ru>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	reiserfs-dev@...esys.com
Subject: Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

On 4/12/07, David Howells <dhowells@...hat.com> wrote:
> Nate Diller <nate.diller@...il.com> wrote:
>
> > Hmmm you're right.  Is your security work going into the next -mm?
>
> I don't know.  Andrew hasn't said anything.  Andrew?  Are you waiting for it
> to go through DaveM's networking tree?
>
> > If so, I'll just re-base this cleanup patch on that ... at the very least I
> > want to get rid of afs_dir_put_page().
>
> That's reasonable.
>
> > Also, did you consider passing the key pointer directly and modifying the
> > readpage actor to simply cast the pointer back, like
> > read_mapping_page(mapping, page, (struct file *)key)?  It seems like a waste
> > to allocate a whole file struct on the stack just for the ->private field.
>
> There's one small problem with that...  And that's filemap_nopage() (it passes
> vma->vm_file to readpage() unconditionally).  Unless, of course, your patches
> fix that too...

But you can't mmap() a directory anyway so ... oh.  Interesting.
afs_file_readpage() does directories too.  The only thing I can think
of then is

struct address_space_operations afs_file_aops = {
        .readpage       = afs_file_readpage,
}
struct address_space_operations afs_dir_aops = {
        .readpage       = afs_key_readpage,
}

int afs_file_readpage(file, page){
    return afs_key_readpage(file->private, page)
}

but that's a lot of code to avoid a single stack allocation.  The
whole fake file pointer thing still strikes me as a little ugly, and
you're definitely not the first one who needed this sort of hackery.
ugh

NATE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/