lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Apr 2007 12:37:04 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Andi Kleen <ak@...ell.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] Add keyboard blink driver On Thu, 12 Apr 2007 21:28:08 +0200 Andi Kleen <ak@...ell.com> wrote: > > I wonder if this facility would be more effective if it were to use > > schedule_delayed_work(). That way, we're using more of the kernel and it > > will more reliably detect kernel deadness. > > Hmm, maybe ?? > +static void do_blink(unsigned long data) > +{ > + static long count; > + if (panic_blink) > + panic_blink(count++); > + blink_timer.expires = jiffies + msecs_to_jiffies(1); > + add_timer(&blink_timer); > +} > + > +static int blink_init(void) > +{ > + printk(KERN_INFO "Enabling keyboard blinking\n"); > + do_blink(0); > + return 0; > +} Would it be better to just not start the timer at all if panic_blink==0? That would improve life rather a lot for people who link this into vmlinux but don't have i8042. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists