linux-kernel - [patch] dont force uclinux mtd map to be root dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704130819.32657.vapier@gentoo.org>
Date:	Fri, 13 Apr 2007 08:19:31 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	greg@...inux.org
Cc:	michele.damico@...re.it, linux-kernel@...r.kernel.org
Subject: [patch] dont force uclinux mtd map to be root dev

the cheesy uclinux mtd maps can be used for more than just the root device, so 
i think we should drop the forcing.  also, i feel like this is a policy 
decision that shouldnt be in the kernel in the first place.  people who have 
been lazy and boot with uclinux mtd maps and dont put root= into their 
commandline can simply add the appropriate root= line either into their 
bootloader or into the compiled in bootargs

Signed-off-by: Mike Frysinger <vapier@...too.org>
---
diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index 389fea2..14ffb1a 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -16,7 +16,6 @@
 #include <linux/kernel.h>
 #include <linux/fs.h>
 #include <linux/major.h>
-#include <linux/root_dev.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/map.h>
 #include <linux/mtd/partitions.h>
@@ -89,10 +88,6 @@ int __init uclinux_mtd_init(void)
 	uclinux_ram_mtdinfo = mtd;
 	add_mtd_partitions(mtd, uclinux_romfs, NUM_PARTITIONS);
 
-	printk("uclinux[mtd]: set %s to be root filesystem\n",
-	     	uclinux_romfs[0].name);
-	ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 0);
-
 	return(0);
 }
 

Content of type "application/pgp-signature" skipped