linux-kernel - RE: [PATCH 1/1] cciss: include scsi/scsi.h unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <558F4D473FD7FE419B019232BF2D37B40B247B@G3W0634.americas.hpqcorp.net>
Date:	Fri, 13 Apr 2007 23:48:28 +0100
From:	"Cameron, Steve" <Steve.Cameron@...com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	<linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<jens.axboe@...cle.com>,
	"Miller, Mike (OS Dev)" <Mike.Miller@...com>,
	<james.bottomley@...eleye.com>
Subject: RE: [PATCH 1/1] cciss: include scsi/scsi.h unconditionally

Andrew Morton [mailto:akpm@...ux-foundation.org] wrote:

> On Fri, 13 Apr 2007 09:23:12 -0500
> Stephen Cameron <steve.cameron@...com> wrote:
>
> > Make cciss unconditionally include scsi/scsi.h
> 
> For what reason?

Because the use of:

        case SCSI_IOCTL_GET_IDLUN:
        case SCSI_IOCTL_GET_BUS_NUMBER:

At first, I thought the solution should be make
cciss dependent on CONFIG_SCSI.  Then James Bottomley
convinced me otherwise, and my first instinct was just
to comment out those cases above, since they fall through
to a default case anyway.  Then Christoph Hellwig commented
that with CONFIG_SCSI, we picked up scsi/scsi.h which made
it compile, but only accidentally.  So then I thought to 
include scsi/scsi.h unconditionally.  If it would be preferable
to just comment out those cases and let the default case
handle it, that's fine be me too.

-- steve
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/